https://bugzilla.redhat.com/show_bug.cgi?id=1315193 --- Comment #9 from Antonio Trande <anto.trande@xxxxxxxxx> --- (In reply to Björn "besser82" Esser from comment #8) > (In reply to Antonio Trande from comment #6) > > Package Review > > ============== > > > > Issues: > > ======= > > > > - Fix this line, please: > > BuildRequires: /usr/bin/sphinx-build > > Why? Any guideline out the telling me, I must not require a certain thing > by it's file-name? Same would apply for the Fedora-package, which is > exactly like this. I don't know why you need to indicate "full path" of a binary file, but okay. > > > > - License files are not marked with %license > > Is that a requirement for EPEL by guidelines? %license hasn't been present > when epel6 or epel7 were released… On epel %license does nothing, but the > same archived using %doc… If I'm not wrong, %license exists on EPEL7 and pushes license files in /usr/share/licenses/package_name instead of /usr/share/doc/package_name on EPEL6. https://fedoraproject.org/wiki/EPEL:Packaging#The_.25license_tag > > > > - -doc sub-package is NOT noarched, also contains > > license files only. Missing documentation files. > > It shouldn't requires main package: > > > > Requires: %{name} = %{version}-%{release} > > > > If it just provides documentation files, should be a > > stand-alone package. > > This is taken excactly 1 by 1 from the Fedora master-branch of CMake… I > don't want to have a too noisy diff between them two… I'm going to discuss > the change with orion, so we can get that sorted out later… > Why is provided a -doc sub-package with license files only? > > > - appdata is not validated. > > https://fedoraproject.org/wiki/Packaging:AppData#app-data-validate_usage > > > > Also it points to a bad .desktop file. I suggest to rename these files as > > cmake3 (package name): > > > > cmake3.desktop > > cmake3.appdata.xml > > --> <id type="desktop">cmake3.desktop</id> > > --> <application> tags are obsoleted > > See > > https://fedoraproject.org/wiki/Packaging:AppData#.appdata.xml_file_creation > > AppData isn't even created nor used on current epel; it is conditionalized. Okay, but as it is now could not work. > > > > [!]: License file installed when any subpackage combination is installed. > > Huh? All licenses are in the main-pkg… If I install any of the other > packages, the main-pkg is pulled in… > > > [-]: If the package is a rename of another package, proper Obsoletes and > > Provides are present. > > [!]: Requires correct, justified where necessary. > > Huh? What's wrong with the Requires of the resulting binary packages? > > > > [?]: Large documentation must go in a -doc subpackage. Large could be size > > (~1MB) or number of files. > > Note: Documentation size is 30720 bytes in 9 files. > > ? Depends by what -doc provides. :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review