Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nss-mdns - glibc plugin for .local name resolution https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=172869 ------- Additional Comments From lpoetter@xxxxxxxxxx 2007-06-22 10:04 EST ------- I have uploaded updated packages now: http://0pointer.de/public/rpms/nss-mdns/ (In reply to comment #37) > Hi, > > It doesn't build on x86_64: > > File not found by glob: /var/tmp/nss-mdns-0.10-1-buildroot/lib64/* I believe I fixed this now, but actually cannot test this because I have no 64bit system around. Please try the updated package. (In reply to comment #38) > The files are being installed into /lib on x86_64 instead of /lib64. The simple > fix is to simply pass "--libdir=/%{_lib}" instead of "--libdir=/lib". Done. (See above) > I note you're not using the %{?dist} tag. There's certainly no requirement that > you do so, but I always ping folks to make sure they understand the issues that > crop up when you don't use it. Nope. I do not understand the issues. I just left in there what Bastien originally put in there. (Blame the frenchies!) Please enlighten me about the implications! I added the dist tag stuff now, just in case. > You need fine-grained dependencies; the package doesn't just require perl, it > needs it there to run its post script. So you need: > Requires(post): perl > Requires(post): /sbin/ldconfig I fixed that now and added fine-grained deps for post, preun, postun. For perl, ldconfig and /bin/sh. (does depending on /bin/sh make any real sense or is it superfluous because it is such a basic tool anyway?) > You can also drop the Requires: perl bit, unless the package actually needs perl > in order to run normally. Unless /etc/nsswitch.conf is patched nss-mdns is entirely useless. You cannot run it manually, it just sits there and takes up some disk space. Thus I would argue that depending on perl during installation does make a lot of sense. I also added a depends on avahi, given that Avahi is required to be installed to make nss-mdns any useful. > X license field says "GPL" but the LICENSE file says "LGPL" Fixed. > X final provides and requires missing some dependencies; see above. > libnss_mdns.so.2()(64bit) > libnss_mdns.so.2(NSSMDNS_0)(64bit) > libnss_mdns4.so.2()(64bit) > libnss_mdns4.so.2(NSSMDNS_0)(64bit) > libnss_mdns4_minimal.so.2()(64bit) > libnss_mdns4_minimal.so.2(NSSMDNS_0)(64bit) > libnss_mdns6.so.2()(64bit) > libnss_mdns6.so.2(NSSMDNS_0)(64bit) > libnss_mdns6_minimal.so.2()(64bit) > libnss_mdns6_minimal.so.2(NSSMDNS_0)(64bit) > libnss_mdns_minimal.so.2()(64bit) > libnss_mdns_minimal.so.2(NSSMDNS_0)(64bit) > nss-mdns = 0.10-1 > = > /bin/sh > /sbin/ldconfig > perl I don't understand this entirely, but I think I fixed this with the fine-grained dependencies, haven't I? > X shared libraries are present; ldconfig is called as necessary but dependency > on ldconfig in %post is not present. Fixed. > X scriptlets present are OK, but the dependencies are off. I don't really understand this either, but this is fixed as well I think, by the fine-grained deps stuff. BTW, how does one generate that review report you posted? That's not rpmlint output, is it? Please review again! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review