https://bugzilla.redhat.com/show_bug.cgi?id=1315020 --- Comment #7 from Jonathan Underwood <jonathan.underwood@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Summary: 1) Fix source URL 2) Add %check 3) Don't bundle tests 4) Encourage upstream to put license headers at top of files More detail below... ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 33 files have unknown license. Detailed output of licensecheck in /home/jgu/Fedora/1315020-python- nmrglue/licensecheck.txt Would be nice if upstream added license headers to these files - it's worth asking, but this isn't a review blocker. [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/python3.5/site-packages, /usr/lib/python3.5 This is a false positive - the python3 packages requires python(abi) = 3.5, which will pull in python, which owns those directories. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.5/site- packages, /usr/lib/python3.5 As above. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2-nmrglue , python3-nmrglue [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. At the very least you should have a %check section which runs python and loads the modules from the buildroot (i.e. not from the sources) - check other python packages for examples of this. Also I note that the fileio has included tests - these could be run during %check. And actually, you probably don't want to be packaging the tests. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-nmrglue-0.5-2.fc25.noarch.rpm python3-nmrglue-0.5-2.fc25.noarch.rpm python-nmrglue-0.5-2.fc25.src.rpm python2-nmrglue.noarch: W: spelling-error %description -l en_US numpy -> bumpy, lumpy, dumpy python2-nmrglue.noarch: W: spelling-error %description -l en_US scipy -> spicy, Scipio python2-nmrglue.noarch: W: spelling-error %description -l en_US matplotlib -> diplomatic python3-nmrglue.noarch: W: spelling-error %description -l en_US numpy -> bumpy, lumpy, dumpy python3-nmrglue.noarch: W: spelling-error %description -l en_US scipy -> spicy, Scipio python3-nmrglue.noarch: W: spelling-error %description -l en_US matplotlib -> diplomatic python-nmrglue.src: W: spelling-error %description -l en_US numpy -> bumpy, lumpy, dumpy python-nmrglue.src: W: spelling-error %description -l en_US scipy -> spicy, Scipio python-nmrglue.src: W: spelling-error %description -l en_US matplotlib -> diplomatic python-nmrglue.src: W: invalid-url Source0: https://github.com/jjhelmus/nmrglue/releases/download/v0.5/nmrglue-0.5.tar.gz HTTP Error 403: Forbidden 3 packages and 0 specfiles checked; 0 errors, 10 warnings. -----> Check the source URL and fix. https://fedoraproject.org/wiki/Packaging:SourceURL Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- python2-nmrglue (rpmlib, GLIBC filtered): python(abi) python2-numpy python2-scipy python3-nmrglue (rpmlib, GLIBC filtered): python(abi) python3-numpy python3-scipy Provides -------- python2-nmrglue: python-nmrglue python2-nmrglue python3-nmrglue: python3-nmrglue Source checksums ---------------- https://github.com/jjhelmus/nmrglue/releases/download/v0.5/nmrglue-0.5.tar.gz : CHECKSUM(SHA256) this package : a05c880bd0d5f0b388156409e18a5618742f829f2532d19970d05b11bfcc6103 CHECKSUM(SHA256) upstream package : a05c880bd0d5f0b388156409e18a5618742f829f2532d19970d05b11bfcc6103 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1315020 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review