https://bugzilla.redhat.com/show_bug.cgi?id=1310796 --- Comment #11 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- BR:git-core is less costly than BR:git. But in fact I don't think you need the BR and -Sgit at all, things usually work with plain patch. The %description is a better summary than the Summary, and the Summary itself seems wrong. I think you should move the %description text into Summary, and maybe add some more details in the %description if possible. Also, there's no need to define %sum, you can put whatever text in the first Summary, and in subsequent ones use %summary to refer to the previous one. + latest version + license is acceptable (MIT) - license file is not present Please package the license file and use %license. I see that the pypi tarball doesn't have a license, upstream screw that up quite often. You can use the github tarball instead. + provides/requires look OK + %python_provide is used + no scriptlets required or necessary rpmlint complains: python-etcd.src:74: W: macro-in-comment %{__python3} You should fix that (%%) because otherwise rpm complains on every build. Looks good otherwise. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review