Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: iscsi-initiator-utils https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225915 bugzilla@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora adrian@xxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |adrian@xxxxxxxx Flag| |fedora-review? ------- Additional Comments From adrian@xxxxxxxx 2007-06-22 08:36 EST ------- The soon attached patches will fix following problems with this package: * empty debuginfo package * E: iscsi-initiator-utils executable-marked-as-config-file /etc/rc.d/init.d/iscsi * E: iscsi-initiator-utils executable-marked-as-config-file /etc/rc.d/init.d/iscsid * W: iscsi-initiator-utils service-default-enabled /etc/rc.d/init.d/iscsi * W: iscsi-initiator-utils service-default-enabled /etc/rc.d/init.d/iscsid * using Requires(...) instead of Prereq * changed buildroot * using --preserve-timestamps for install * replaced hardcoded paths with rpm macros * conditional execution of chkconfig in scriptlets The remaining warnings from rpmlint: E: iscsi-initiator-utils non-readable /etc/iscsi/iscsid.conf 0600 W: iscsi-initiator-utils summary-not-capitalized iSCSI daemon and utility programs E: iscsi-initiator-utils statically-linked-binary /sbin/iscsistart W: iscsi-initiator-utils no-reload-entry /etc/rc.d/init.d/iscsi W: iscsi-initiator-utils no-reload-entry /etc/rc.d/init.d/iscsid The only which should probably be looked at is to get FESCO approval for statically-linked-binary /sbin/iscsistart. As I get following warning from the compiler: cc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables -Wall -Wstrict-prototypes -I../include -DLinux -DNETLINK_ISCSI=8 -D_GNU_SOURCE -static netlink.o util.o io.o auth.o login.o log.o md5.o sha1.o iscsi_sysfs.o idbm.o initiator.o queue.o actor.o mgmt_ipc.o isns.o transport.o iscsistart.o statics.o -o iscsistart login.o: In function `resolve_address': /home/adrian/devel/fedora/rpms/iscsi-initiator-utils/F-7/open-iscsi-2.0-865/usr/login.c:168: warning: Using 'getaddrinfo' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking I am not sure, with this warning message, if static linking makes much sense here. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review