[Bug 1315022] Review Request: xfpanel-switch - A simple application to manage Xfce panel layouts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1315022



--- Comment #5 from Mukundan Ragavan <nonamedotc@xxxxxxxxx> ---
(In reply to gil cattaneo from comment #3)
> Issues:
> =======
> - Package contains BR: python2-devel or python3-devel

Done.

> - Package installs a %{name}.desktop using desktop-file-install or desktop-
>   file-validate if there is such a file.
> 
> Please, use desktop-file-validate
> https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-
> install_usage
> and see
> https://fedoraproject.org/wiki/Packaging:Scriptlets#desktop-database
> 

Done.

> [!]: Package must own all directories that it creates.
>      Note: Directories without known owners: /usr/share/xfpanel-switch,
> /usr/share/xfpanel-switch/xfpanel-switch
> 
> xfpanel-switch.noarch: E: description-line-too-long C With the modular Xfce
> Panel, a multitude of panel layouts can be created. This tool makes it
> possible to backup,
>

Fixed.

> xfpanel-switch.noarch: W: no-version-in-last-changelog
> 

Fixed.

> xfpanel-switch.noarch: W: spurious-executable-perm
> /usr/share/xfpanel-switch/layouts/Redmond.tar.bz2
> xfpanel-switch.noarch: W: spurious-executable-perm
> /usr/share/xfpanel-switch/layouts/GNOME 2.tar.bz2
> xfpanel-switch.noarch: W: spurious-executable-perm
> /usr/share/xfpanel-switch/layouts/Xfce 4.12.tar.bz2
> 
> xfpanel-switch.noarch: W: install-file-in-docs
> /usr/share/doc/xfpanel-switch/INSTALL
>

Removed.

> Missing appadata file. Please, can you add one?
> https://fedoraproject.org/wiki/Packaging:Guidelines#AppData_files

Added a simple appdata file now. Will file a bug report upstream to have it
included in the tarball.

(In reply to gil cattaneo from comment #4)
> xfpanel-switch.noarch: W: install-file-in-docs
> /usr/share/doc/xfpanel-switch/INSTALL
> please, remove

Done.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]