[Bug 1315022] Review Request: xfpanel-switch - A simple application to manage Xfce panel layouts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1315022



--- Comment #3 from gil cattaneo <puntogil@xxxxxxxxx> ---
Issues:
=======
- Package contains BR: python2-devel or python3-devel
- Package installs a %{name}.desktop using desktop-file-install or desktop-
  file-validate if there is such a file.

Please, use desktop-file-validate
https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage
and see
https://fedoraproject.org/wiki/Packaging:Scriptlets#desktop-database

[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/xfpanel-switch,
/usr/share/xfpanel-switch/xfpanel-switch

xfpanel-switch.noarch: E: description-line-too-long C With the modular Xfce
Panel, a multitude of panel layouts can be created. This tool makes it possible
to backup,

xfpanel-switch.noarch: W: no-version-in-last-changelog

xfpanel-switch.noarch: W: spurious-executable-perm
/usr/share/xfpanel-switch/layouts/Redmond.tar.bz2
xfpanel-switch.noarch: W: spurious-executable-perm
/usr/share/xfpanel-switch/layouts/GNOME 2.tar.bz2
xfpanel-switch.noarch: W: spurious-executable-perm
/usr/share/xfpanel-switch/layouts/Xfce 4.12.tar.bz2

xfpanel-switch.noarch: W: install-file-in-docs
/usr/share/doc/xfpanel-switch/INSTALL

Maybe you could remove:
mkdir -p %{buildroot}%{_datadir}/licenses/%{name}
cp -p COPYING %{buildroot}%{_datadir}/licenses/%{name}/
and use (for EPEL only, see https://fedorahosted.org/fpc/ticket/586)
%{!?_licensedir:%global license %%doc}
%license COPYING
Missing appadata file. Please, can you add one?
https://fedoraproject.org/wiki/Packaging:Guidelines#AppData_files

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]