https://bugzilla.redhat.com/show_bug.cgi?id=1314895 Björn "besser82" Esser <fedora@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED CC|package-review@lists.fedora | |project.org | Resolution|--- |RAWHIDE Last Closed| |2016-03-05 04:49:24 --- Comment #3 from Björn "besser82" Esser <fedora@xxxxxxxxxxx> --- (In reply to Christian Dersch from comment #2) > Looks good to me => Approved > > Just some comments: > * Please fix macros in comments on SCM import > * You write: "This package is still WIP by upstream", I approved because the > package is formally ok, but to be honest, I think you should use something > like COPR until it is usable. Especially think about ABI and API breaks > during development when you push this to stable releases. Confirm > https://fedoraproject.org/wiki/Updates_Policy#All_other_updates Thank you for the quick review! ^^ Macros will be properly comented out. I won't push it to anything but Rahwide, before the first release will be there; it will be needed for later releases of Shogun and all. Since I'm the main upstream-author and all and there are currently no consumers of that lib, everything will go fine. =) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review