https://bugzilla.redhat.com/show_bug.cgi?id=1305669 Jerry James <loganjerry@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #4 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to greg.hellings from comment #3) > This is copied from upstream's README.md, as auto-generated by gem2rpm. I > have corrected the text in the spec file as it is unlikely that this will be > updated via the automation mechanism and also submitted a PR upstream to fix > the README.md file: https://github.com/evanphx/benchmark-ips/pull/61 You will need to correct the bug summary as well. That has to match the summary in the spec file before asking for the package to be created. > > - Is the Rakefile really useful in the documentation? > > I can't say for sure, but it seems to be included by default in the gem2rpm > process. It gives basic information about how the gemspec file is generated > and how tests should be run. I have no objections to removing it if you'd > like. If it is useful, then I'm okay with it staying. I see no further issues, so this package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review