[Bug 1301116] Review Request: libcxl - Coherent accelerator interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1301116



--- Comment #15 from Dan Horák <dan@xxxxxxxx> ---
additional comments:
- please update release for each iteration, it hard to track the changes made
if it's kept the same and spec and srpms are overridden
- you can drop also the "build" dir for man pages, it's a no-op at the end
mkdir -p build/man3
cp man3/*.3 build/man3
- I would use only VERS_LIB=%{version} otherwise it appends also ".1.fc24"
which is not correct IMO
- the libcxl.so symlink need to be created manually or the makefile be updated
to create it, then "%files" should have
%{_libdir}/libcxl.so.*
and "%files devel" then
%{_libdir}/libcxl.so

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]