https://bugzilla.redhat.com/show_bug.cgi?id=1301116 --- Comment #12 from Michel Normand <normand@xxxxxxxxxxxxxxxxxx> --- Thank you Dan for the review. I modified my spec file to address the reported issues, except for "spelling error" I am not able to verify. (see comment below) (In reply to Dan Horák from comment #11) > formal review is here, see the notes explaining OK* and BAD statuses below: > > {CUT] ... > > - do not explicitly compress the man pages, it's done automagically by > rpmbuild > - you should skip the "rm -rf" in %install, rpmbuild does that automatically > - use a verbose build so we can confirm what compiler flags are used, the > distro-wide flags from $RPM_OPT_FLAGS/%{optflags} must be used > (https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags) > - rpmlint complains a bit > libcxl.ppc64le: W: spelling-error %description -l en_US Userland -> User > land, User-land, Slanderous > libcxl.ppc64le: W: spelling-error %description -l en_US powerpc -> PowerPC > libcxl.ppc64le: W: spelling-error %description -l en_US cxl -> cl, cal, col > libcxl.ppc64le: W: spelling-error %description -l en_US txt -> text, ext, tit > libcxl.ppc64le: W: spelling-error %description -l en_US userland -> user > land, user-land, slanderous from where are coming the "spelling-error" check ? If I run myself the rpmlint with no specific option on generated rpm file I do not have such warning. Do you have a specific configuration file ? > libcxl.ppc64le: E: no-ldconfig-symlink /usr/lib64/libcxl.so > 3 packages and 0 specfiles checked; 1 errors, 5 warnings. > - libcxl.so should be a symlink to the actual library file that contains > version info (eg. soname version) in the name, with the symlink in devel > subpackage -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review