Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ocaml-findlib - Objective CAML package manager and build helper https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240557 bugzilla@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Product|Fedora Extras |Fedora ------- Additional Comments From lxtnow@xxxxxxxxx 2007-06-22 01:03 EST ------- some comments: * Mock failed to build on F-7_x86_64: -------------------------------------------------------------------- Welcome to findlib version 1.1.2pl1 Configuring core... Testing threading model... Testing DLLs... Configuring libraries... labltk: found camlp4: found Configuration for dbm written to site-lib-src/dbm/META Configuration for dynlink written to site-lib-src/dynlink/META Configuration for graphics written to site-lib-src/graphics/META Configuration for num written to site-lib-src/num/META Configuration for num-top written to site-lib-src/num-top/META Configuration for str written to site-lib-src/str/META Configuration for threads written to site-lib-src/threads/META Configuration for unix written to site-lib-src/unix/META Configuration for stdlib written to site-lib-src/stdlib/META Configuration for bigarray written to site-lib-src/bigarray/META Configuration for labltk written to site-lib-src/labltk/META Configuration for camlp4 written to site-lib-src/camlp4/META Detecting compiler arguments: FAILED error: Bad exit status from /var/tmp/rpm-tmp.91630 (%build) -------------------------------------------------------------------- * Your release tag doesn't quite good. As your package contains pre-release it should be more like this: 1.1.2-0.1.pl1 instead of 1.1.2pl1-1 * typo: from %build stage -bindir %[_bindir} instead of -bindir %[_mandir} About -config %{_sysconfdir}/ocamlfind.conf, its provided by this package so how its can get this file from /etc for the build or "it is just to mention where the installed ocaml-findlib package can get it ?" * INSTALL file have to be remove from %doc. You provide a pre-compiled package. * You don't have to exlcude files that you pasted on %files section of subpackages, you can remove your %exclude lines from main package. They will automatically add to subpackage. * You should add Guide-html subdirectory to docdir. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review