https://bugzilla.redhat.com/show_bug.cgi?id=1268716 --- Comment #43 from Jared Smith <jsmith.fedora@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains BR: python2-devel or python3-devel - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: make See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 - License says it's GPL v3, but licensecheck finds many other licenses - Contains bundled versions of bootstrap and select2 (admin/www), but those don't follow the web assets packaging guidelines. See https://fedoraproject.org/wiki/Packaging:Web_Assets and https://fedoraproject.org/wiki/Packaging:JavaScript for these files. - The package shouldn't start on installation -- that's frowned upon in Fedora - Subpackages should have strictly versioned requires on the main package - You should use %global instead of %define, unless you really need only locally defined submacros within other macro definitions (a very rare case). - Make sure that the spec file used to build the SRPM is the same one linked in the bugzilla ticket. - I'm still getting an SELinux alert on the "machines" directory when running the 'peerStats' utility. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "GPL (v3 or later)", "Unknown or generated", "MIT/X11 (BSD like)", "*No copyright* ISC", "ISC", "GPL (v3 or later) (with incorrect FSF address)", "BSD (3 clause)", "GPL (v2 or later) (with incorrect FSF address)", "BSD (2 clause)", "BSD (3 clause) MIT/X11 (BSD like)". 2365 files have unknown license. Detailed output of licensecheck in /home/jsmith/Git/FedoraReview/1268716-cjdns/licensecheck.txt [!]: License file installed when any subpackage combination is installed. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/selinux/targeted, /usr/lib/systemd/system, /usr/libexec/cjdns, /usr/lib/systemd [x]: %build honors applicable compiler flags or justifies otherwise. [!]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 92160 bytes in 10 files. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: Uses parallel make %{?_smp_mflags} macro. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in cjdns- selinux , cjdns-tools , cjdns-python , cjdns-graph , cjdns-debuginfo [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [!]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define use_embedded 1, %define use_embedded 0, %define use_systemd 0, %define use_systemd 1, %define use_upstart 1, %define use_upstart 0, %define with_admin 0, %define with_python 1 [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: cjdns-17.3-6.fc24.x86_64.rpm cjdns-selinux-17.3-6.fc24.x86_64.rpm cjdns-tools-17.3-6.fc24.x86_64.rpm cjdns-python-17.3-6.fc24.noarch.rpm cjdns-graph-17.3-6.fc24.noarch.rpm cjdns-debuginfo-17.3-6.fc24.x86_64.rpm cjdns-17.3-6.fc24.src.rpm cjdns.x86_64: W: spelling-error %description -l en_US scalability -> availability, sociability, implacability cjdns.x86_64: E: missing-call-to-chdir-with-chroot /usr/sbin/cjdroute cjdns.x86_64: E: missing-call-to-chdir-with-chroot /usr/libexec/cjdns/sybilsim cjdns.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/cjdns/README_RU.md cjdns.x86_64: E: non-standard-dir-perm /var/empty/cjdns 100 cjdns.x86_64: W: spurious-executable-perm /usr/share/man/man5/cjdroute.conf.5.gz cjdns.x86_64: W: non-standard-dir-in-var empty cjdns-tools.x86_64: W: no-documentation cjdns-tools.x86_64: W: no-manual-page-for-binary dumpLinks cjdns-tools.x86_64: W: no-manual-page-for-binary search cjdns-tools.x86_64: W: no-manual-page-for-binary pingAll cjdns-tools.x86_64: W: no-manual-page-for-binary dumptable cjdns-tools.x86_64: W: no-manual-page-for-binary sessionStats cjdns-tools.x86_64: W: no-manual-page-for-binary peerStats cjdns-tools.x86_64: W: no-manual-page-for-binary pathfinderTree cjdns-tools.x86_64: W: no-manual-page-for-binary dumpRumorMill cjdns-tools.x86_64: W: no-manual-page-for-binary cjdnslog cjdns-python.noarch: W: no-manual-page-for-binary getLinks cjdns-python.noarch: W: no-manual-page-for-binary cjdnsa cjdns-python.noarch: W: no-manual-page-for-binary ip6topk cjdns-python.noarch: W: no-manual-page-for-binary pingAll.py cjdns-python.noarch: W: no-manual-page-for-binary trashroutes cjdns-python.noarch: W: no-manual-page-for-binary searches cjdns-python.noarch: W: no-manual-page-for-binary pktoip6 cjdns-python.noarch: W: no-manual-page-for-binary findnodes cjdns-graph.noarch: W: no-documentation cjdns-graph.noarch: W: no-manual-page-for-binary dumpgraph cjdns-graph.noarch: W: no-manual-page-for-binary drawgraph cjdns-graph.noarch: W: no-manual-page-for-binary graphStats cjdns.src: W: spelling-error %description -l en_US scalability -> availability, sociability, implacability cjdns.src:405: W: macro-in-%changelog %{_libdir} cjdns.src:69: W: mixed-use-of-spaces-and-tabs (spaces: line 29, tab: line 69) 7 packages and 0 specfiles checked; 3 errors, 29 warnings. Rpmlint (debuginfo) ------------------- Checking: cjdns-debuginfo-17.3-6.fc24.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- cjdns.x86_64: W: spelling-error %description -l en_US scalability -> availability, sociability, implacability cjdns.x86_64: E: missing-call-to-chdir-with-chroot /usr/libexec/cjdns/sybilsim cjdns.x86_64: E: missing-call-to-chdir-with-chroot /usr/sbin/cjdroute cjdns.x86_64: E: non-standard-dir-perm /var/empty/cjdns 100 cjdns.x86_64: W: spurious-executable-perm /usr/share/man/man5/cjdroute.conf.5.gz cjdns.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/cjdns/README_RU.md cjdns.x86_64: W: non-standard-dir-in-var empty cjdns-tools.x86_64: W: no-documentation cjdns-tools.x86_64: W: no-manual-page-for-binary cjdnslog cjdns-tools.x86_64: W: no-manual-page-for-binary dumpLinks cjdns-tools.x86_64: W: no-manual-page-for-binary sessionStats cjdns-tools.x86_64: W: no-manual-page-for-binary pathfinderTree cjdns-tools.x86_64: W: no-manual-page-for-binary peerStats cjdns-tools.x86_64: W: no-manual-page-for-binary pingAll cjdns-tools.x86_64: W: no-manual-page-for-binary dumpRumorMill cjdns-tools.x86_64: W: no-manual-page-for-binary dumptable cjdns-tools.x86_64: W: no-manual-page-for-binary search cjdns-graph.noarch: W: no-documentation cjdns-graph.noarch: W: no-manual-page-for-binary graphStats cjdns-graph.noarch: W: no-manual-page-for-binary drawgraph cjdns-graph.noarch: W: no-manual-page-for-binary dumpgraph cjdns-python.noarch: W: no-manual-page-for-binary findnodes cjdns-python.noarch: W: no-manual-page-for-binary pktoip6 cjdns-python.noarch: W: no-manual-page-for-binary searches cjdns-python.noarch: W: no-manual-page-for-binary trashroutes cjdns-python.noarch: W: no-manual-page-for-binary pingAll.py cjdns-python.noarch: W: no-manual-page-for-binary cjdnsa cjdns-python.noarch: W: no-manual-page-for-binary ip6topk cjdns-python.noarch: W: no-manual-page-for-binary getLinks 6 packages and 0 specfiles checked; 3 errors, 26 warnings. Diff spec file in url and in SRPM --------------------------------- --- /home/jsmith/Git/FedoraReview/1268716-cjdns/srpm/cjdns.spec 2016-03-01 09:46:42.900705383 -0500 +++ /home/jsmith/Git/FedoraReview/1268716-cjdns/srpm-unpacked/cjdns.spec 2016-02-29 22:28:33.000000000 -0500 @@ -67,5 +67,5 @@ Patch8: cjdns.warnings.patch # Man pages -Patch9: cjdns.man.patch +Patch9: cjdns.man.patch BuildRequires: nodejs, make, nodejs-ronn Requires -------- cjdns-selinux (rpmlib, GLIBC filtered): /bin/sh cjdns policycoreutils selinux-policy cjdns (rpmlib, GLIBC filtered): /bin/sh libc.so.6()(64bit) libnacl.so.0()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libstdc++.so.6()(64bit) rtld(GNU_HASH) shadow-utils cjdns-tools (rpmlib, GLIBC filtered): /usr/bin/env nodejs cjdns-graph (rpmlib, GLIBC filtered): /usr/bin/python2 cjdns-python python-networkx cjdns-debuginfo (rpmlib, GLIBC filtered): cjdns-python (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python2 python Provides -------- cjdns-selinux: cjdns-selinux cjdns-selinux(x86-64) cjdns: bundled(libuv) cjdns cjdns(x86-64) cjdns-tools: cjdns-tools cjdns-tools(x86-64) cjdns-graph: cjdns-graph cjdns-debuginfo: cjdns-debuginfo cjdns-debuginfo(x86-64) cjdns-python: cjdns-python Source checksums ---------------- https://github.com/cjdelisle/cjdns/archive/cjdns-v17.3.tar.gz : CHECKSUM(SHA256) this package : 3193df651ad9c00f31ab04feb33f801645996f6647c89b63bcc327b48e17e602 CHECKSUM(SHA256) upstream package : 3193df651ad9c00f31ab04feb33f801645996f6647c89b63bcc327b48e17e602 Generated by fedora-review 0.6.0 (7737a2a) last change: 2015-11-26 Command line :./try-fedora-review -b 1268716 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api, C/C++ Disabled plugins: Java, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review