https://bugzilla.redhat.com/show_bug.cgi?id=1305496 jiri vanek <jvanek@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(jvanek@xxxxxxxxxx | |) | --- Comment #5 from jiri vanek <jvanek@xxxxxxxxxx> --- (In reply to Tomas Repik from comment #4) > (In reply to jiri vanek from comment #3) > > [!]: %check is present and all tests pass. > > > > Unless there is some reason I cant see, i probably insists execution of > > tests during build. there is even junit in In original sources. > > Tests are executed during build, using maven-surefire-plugin. Only > HistogramPerfTest is not run, but I don't think it's necessary. As [1] > tells: "Optional %check section > Runs projects integration tests. Unit test are usually run in %build > section, so if there are no integration tests available, this section is > omitted" I always forget that forcing maven run build and tests one by one is a bit hackisch. So yes, I donto wont to foorce you to split build and test run. And integration tests seems really not necessary. > > > [!]: Package functions as described. > > > > There is quite a lot interesting things in the source tarball. One of them > > is launcher. Others are web based histrograms. I would expect them to work > > in installed application. Rightnow they are just missing. > > I can't see any more files needed to be installed. Can you be more specific? > > [1] https://fedorahosted.org/released/javapackages/doc/#_example_rpm_project You are saying yoursef: 48: %jpackage_script org.fedoraproject.helloworld.HelloWorld "" "" %{name} helloworld true :) More serious - there is launcher HistogramLogProcessor. I watched it more closely, and although it probably deserves to be rewritten and packed inside as launcher, it do not seems to be doing main functionality of this package. Originally I thougth that this program will take an fil/input of numbers and create histogram..image... But looking to list of mainclasses: src/perf/java/org/HdrHistogram/HistogramPerfTest.java: public static void main(String[] args) { src/main/java/org/HdrHistogram/HistogramLogProcessor.java: public static void main(final String[] args) { src/examples/java/SimpleHistogramExample.java: public static void main(final String[] args) { My assumption was probably wrong. Thoughts? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review