[Bug 1310145] Review Request: python-igor - Parser for Igor Binary Waves (.ibw) and Packed Experiment (.pxp) files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1310145



--- Comment #8 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
Thanks for the review.

Package is updated to a git snapshot, it has some fixes, and in particular:
- also installs /usr/bin/igorbinarywave
- clears up the licensing in favour of LGPLv3+

I patched the test output by hand to pass the tests under Python3. I would love
to use the same sources for 2 and 3, but this seems to be one of those packages
where this is very hard. Python 2 and 3 simply have different outputs and
behaviour for binary structures and I don't see a way around this.

Here I get proper shebangs with /usr/bin/python2. I added a test in %check to
verify that this remains true.

I decided to keep the executable running under python2. If the python3 version
works properly, I can switch later. I added a comment in the spec file.

My HTTPS certificate works in firefox... Too bad that the set of CAs is not
shared between system tools and the most popular browser. But you are right, I
should use a certificate that is widely accepted.

I changed the BR and Provides. Seems to build fine in mock now.

New urls:
spec: https://zbyszek.fedorapeople.org/python-igor.spec
srpm:
https://zbyszek.fedorapeople.org/python-igor-0.2-3.20150408git2c2a79d.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]