[Bug 1310145] Review Request: python-igor - Parser for Igor Binary Waves (.ibw) and Packed Experiment (.pxp) files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1310145



--- Comment #2 from Jonathan Underwood <jonathan.underwood@xxxxxxxxx> ---
Also, building fails:

+ cd /builddir/build/BUILD
+ cd igor-0.2
+ nosetests-2.7 --with-doctest --doctest-tests igor test
/var/tmp/rpm-tmp.jGiA96: line 31: nosetests-2.7: command not found

Your Requires for python[3]-nose should in fact by BuildRequires.

Please fix (and it would be helpful to confirm your package builds in mock
before uploading the new vesion).

Also, your subpackages need to use the %python_provide macro:

https://fedoraproject.org/wiki/Packaging:Python

Regarding  the failing tests - you should be able to use sed to convert the b''
strings to something suitable - it would be better to have these tests passing,
and a patch sent upstream.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]