[Bug 1312408] Review Request: python-sphinx-testing - Testing utility classes and functions for Sphinx extensions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1312408

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |zbyszek@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zbyszek@xxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
The description is unclear: is it classes for writing unit tests? Can you
reword the description so it unambiguous what the purpose of the package is.

In check, use "nosetests-%{python3_version}", don't hardcode the version.
And nosetests-%{python2_version}" for the python 2 tests.

When you remove the shebang line, the file is modified, and there rule that
timestamps of unmodified files should be preserved does not apply anymore. You
can just use plain old "sed -i".

Would it work if you built python 2 and 3 versions from the same build
directory?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]