[Bug 1289970] Review Request: python-openstacksdk - An SDK for building applications to work with OpenStack

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1289970

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
                 CC|                            |zbyszek@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zbyszek@xxxxxxxxx
              Flags|                            |fedora-review+



--- Comment #9 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
You don't need to repeat the Summary text. After the first instance you can
refer the the previous one with %{summary}. And for tests you you can use
"Summary: %{summary} - test files".

Also, "An " in the summary is not useful, listings look better without the
article.

Very nice package.

+ license is acceptable (ASL 2)
+ license file is present, %license is used
- not the latest version (0.7.4 is latest on pypi)
+ no scriptlets
+ %check is present and passes
+ rpmlint is happy (only no-documentation warning)
+ provides and requires seem right

Package is APPROVED.

Please update to the latest version.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]