https://bugzilla.redhat.com/show_bug.cgi?id=1308367 Richard Shaw <hobbes1069@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hobbes1069@xxxxxxxxx --- Comment #9 from Richard Shaw <hobbes1069@xxxxxxxxx> --- A little spec review: 1. rm -rf $RPM_BUILD_ROOT in %install isn't needed anymore (for a long time). 2. "cp -f" in %install You shouldn't need to force anything as nothing should already be there but you should preserve time stamps so use "cp -p" instead. 3. find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';' Since this appears to be a cmake project I would be surprised to see libtool archives in it but I haven't tried building the software yet. 4. %{_libdir}/libraknet.so Fedora pretty much requires libraries to carry a soversion for anything going into %{_libdir}. This will take some more thought. I have a project that I have to maintain the soversion manually. It's not terribly problematic but I do have to check changes against abi-compliance-checker to see if I need to bump the version. 5. %changelog a. There should be one line between changelog entries. b. Your name and email address should be in them (it's ok to mangle the email address if that's a concern). c. The release should be on the end. So your current changelog would become: %changelog * Sat Feb 20 2016 John M. Harris <email address> - 4.081-3 - Use actual RakNet sources and CMake to generate build files. * Mon Feb 15 2016 John M. Harris <email address> - 4.081-2 - Updated spec file to use a wildcard for headers, not for libraries. * Mon Feb 15 2016 John M. Harris <email address> - 4.081-1 - Initial packaging of raknet. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review