https://bugzilla.redhat.com/show_bug.cgi?id=1309707 --- Comment #1 from Denis Fateyev <denis@xxxxxxxxxxx> --- At the first glance, before the review: 1) testssl uses `nslookup` for resolving which is missing in Requires. $ dnf provides '*bin/nslookup' ... bind-utils-32:9.10.3-1.fc23.x86_64 : Utilities for querying DNS name servers -- should be added to R's. 2) testssh uses mapping file(s) which isn't installed. You can provide `mapping-rfc.txt` in `/usr/share/testssh` (via macro: `%{_datarootdir}/testssh`). Also, a small patch which sets the new proper `mapping-rfc.txt` location will be required; 3) mkdir -p %{buildroot}%{_bindir} cp -p %{name}.sh %{buildroot}%{_bindir}/%{name} can be replaced with one command (which is also sets proper permissions): install -Dpm 0755 %{name}.sh %{buildroot}%{_bindir}/%{name} 4) util-linux (hexdump), grep (grep, egrep), gawk (awk) also needed in Requires; 5) openssl version should be constrained (>= 1.0) as mentioned in Readme. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review