https://bugzilla.redhat.com/show_bug.cgi?id=1268716 --- Comment #31 from Jared Smith <jsmith.fedora@xxxxxxxxx> --- The package is coming along nicely, but isn't yet ready for approval. Here's my running list of things that should be addressed: - Fix the license tag to be "GPLv3" - Permissions on files are set properly. Note: See rpmlint output See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions - Package contains BR: python2-devel or python3-devel - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: make See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 - Package uses either %{buildroot} or $RPM_BUILD_ROOT Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: Cannot find bencode.py.LICENSE.txt in rpm(s) See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text - The main package should own the %{_libdir}/cjdns directory - Do you need FPC exception approval for bundled nacl and libuv libraries? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review