https://bugzilla.redhat.com/show_bug.cgi?id=1310607 --- Comment #3 from T. Orsava <torsava@xxxxxxxxxx> --- (In reply to Bohuslav "Slavek" Kabrda from comment #2) > - All the dependencies are used in python3 version, but cssutils is python2 > - is there any reason for that? IMO it's a typo. Since cssutils is only an optional dependency, I have commented that line out to be readded in the future when cssutils is packaged for Python 3. > - There are quite a lot hashbangs that point to /usr/bin/env. While there is > nothing in guidelines (that I know of) that would prohibit this, I'd advise > changing these to point to /usr/bin/python3. Consider this - someone might > try to run this in an environment where "/usr/bin/env python3" points to > something else than /usr/bin/python3. qutebrowser would likely fail since it > wouldn't find dependencies (dependencies that it has been built with and > tested with by you as a packager). By replacing the hashbangs, qutebrowser > can keep working even in environments like this (well, for the most part, > anyway). I have added a line into the %build section that changes those hashbangs accordingly. > > Otherwise everything looks good - the package builds and runs fine, rpmlint > output is clean, licensing is good and specfile looks very nice. Once the > above problems are solved, this package can be approved (oh, and I like that > it's Python 3!) Thanks for all your input, hopefully now it'll be all ok! Spec URL: https://torsava.fedorapeople.org/qutebrowser.spec SRPM URL: https://torsava.fedorapeople.org/qutebrowser-0.5.1-1.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review