[Bug 1309691] Review Request: hid-replay - debug tools for HID devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1309691



--- Comment #4 from Benjamin Tissoires <btissoir@xxxxxxxxxx> ---
Spec URL:
https://people.freedesktop.org/~tissoire/hid-replay-rpm-v3/hid-replay.spec
SRPM URL:
https://people.freedesktop.org/~tissoire/hid-replay-rpm-v3/hid-replay-0.7.1-1.fc23.src.rpm

(In reply to Peter Hutterer from comment #3)
> COPYING is still marked as %doc, should be %license... oh wait, nevermind.
> just found it in the %description. Just replace the %doc COPYING with
> %license COPYING and that's it.

OK, removed the extra %license and updated the correct field in %files (sorry
for my misunderstanding).

> 
> I noticed that COPYING is GPLv2 but the source files are v2 or later? (and

This should be fine. The GPLv2 text mentions the case when the sources declare
the "or later" mention.

> the ccan bits are public domain or MIT)

Good catch. Updated the .spec to reflect that.

> 
> All the rest looks good now, if you can fix those two up the package is ready

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]