[Bug 1286885] Review Request: orthorobot - A perspective based puzzle game

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1286885



--- Comment #5 from Jiri Konecny <jkonecny@xxxxxxxxxx> ---
I'm taking this review.

Hello Jeremy,

good job so far.
There should be manpage so if there is --help in this program then you can
generate manpage from there, another solution is to use their documentation
somewhere. You can then use tools like a2x which can convert asciidoc to
manpage. I hope they have something somewhere :).

Also you should validate the desktop file in the %check section with:

desktop-file-validate %{buildroot}/%{_datadir}/applications/%{name}.desktop

Jirka

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]