[Bug 1264712] Review Request: dub - The D package manager

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1264712

Neal Gompa <ngompa13@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ngompa13@xxxxxxxxx



--- Comment #6 from Neal Gompa <ngompa13@xxxxxxxxx> ---
So a few things here...

* The Source should point to a canonical URL. I just tested
https://github.com/D-Programming-Language/dub/archive/v0.9.24/dub-0.9.24.tar.gz,
and that worked, so I suggest that you replace your Source with the following:

Source0:
https://github.com/D-Programming-Language/%{name}/archive/v%{version}/%{name}-%{version}.tar.gz

* You're already pulling in libcurl-devel, so you don't need libcurl listed as
a BuildRequires.

* I'm unsure if Fedora allows alternate languages in the package spec. If it's
permitted, that's great, otherwise you may need to rip it out.

* Please add the available completions to the main package and add the examples
as a %doc.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]