[Bug 1310294] Review Request: sqlcipher - An SQLite extension that provides 256 bit AES encryption of database files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1310294

Rex Dieter <rdieter@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rdieter@xxxxxxxxxxxx



--- Comment #1 from Rex Dieter <rdieter@xxxxxxxxxxxx> ---
Offhand, in -devel subpkg I see:

1.  
%{_includedir}/%{name}/sqlite3ext.h
%{_includedir}/%{name}/sqlite3.h

which implies that
%{_includedir}/%{name}
dir is not owned, imo, easier to replace those 2 lines with just:

%{_includedir}/sqlcipher/

(personal preference of mine to not use %name macro here, so that it'll
continue to work regardless of the actual package name)

2. 
%{_libdir}/libsqlcipher-3.8.10.2.so.0
%{_libdir}/libsqlcipher-3.8.10.2.so.0.8.6

these libraries should be in the main pkg (not -devel), and include ldconfig
scriptlets

3.
%{_libdir}/libsqlcipher.la

libtool archives should not be included in packaging, this file should be
deleted or otherwise excluded.

4.  %package -devel MUST have a tighter dependency on the main pkg, instead of
Requires: %{name} = %{version}
use
Requires: %{name}%{?_isa} = %{version}-%{release}

5. SHOULD document why these compiler flags are needed in a .spec comment
CFLAGS="-DSQLITE_HAS_CODEC -DSQLITE_TEMP_STORE=2"
LDFLAGS="-lcrypto"

6. While you're at it, MUST respect distro compiler flags, using (something
like)
CFLAGS="%{optflags} -DSQLITE_HAS_CODEC -DSQLITE_TEMP_STORE=2"
LDFLAGS="%{?__global_ldflags} -lcrypto"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]