https://bugzilla.redhat.com/show_bug.cgi?id=1310092 Richard Shaw <hobbes1069@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hobbes1069@xxxxxxxxx --- Comment #1 from Richard Shaw <hobbes1069@xxxxxxxxx> --- Here's a quick spec file review: - Typographical: Space in name tag "Name :" - Why x86_64 only? - The %prep section isn't empty as it contains %setup, just do: %prep %setup - %pre is optional, just drop it if you don't need any scripts. - Use of %post questions: -- chmod in %post: Why can it not be installed in this mode? Or does the binary modify this when run? -- Why copy the binary in %post? Can't it just be installed in bin directly? -- No installing to /usr/local, this package would be part of Fedora and should install to the system location, using the proper macro, %{_bindir}. - %clean shouldn't be needed unless you have multiple Source files. - %attr use in %files: This is usually only used to set users/groups for non-root. Setting the mode should be done correctly by %make_install. Additionally it's more common to fix permissions in %install rather than in %files. - In the case where you really want /usr/lib on x86_64 the better method is to use %{_prefix}/lib. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review