https://bugzilla.redhat.com/show_bug.cgi?id=1309795 --- Comment #4 from Antonio Trande <anto.trande@xxxxxxxxx> --- (In reply to David Tardon from comment #1) > * If this is only for Fedora and EPEL-7, why do you change __global_ldflags > for 0%{rhel} < 7? I'm going to package for EPEL6 too, even if it is not ready yet. > * Is there a reason you are not passing %{?_smp_mflags} to make to allow > parallel build? It's not supported or compiler fails easily. > * Is there a reason to BuildRequire pkgconfig? I don't see it being used > anywhere... Indeed, it's useless. > * IMO the library symlinks should be relative. > * Consider putting the variables repeated in both make calls into a macro. > * Consider putting repeated parts of the gfortran calls into a macro. > * Consider using a build conditional > (http://www.rpm.org/wiki/PackagerDocs/ConditionalBuilds) for the conditional > handling of docs. > * Consider using install consistently (instead of cp -p, possibly also > instead of mkdir -p). Thank you. Spec URL: https://sagitter.fedorapeople.org/qr_mumps/qr_mumps.spec SRPM URL: https://sagitter.fedorapeople.org/qr_mumps/qr_mumps-1.2-2.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review