https://bugzilla.redhat.com/show_bug.cgi?id=1309691 Peter Hutterer <peter.hutterer@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |peter.hutterer@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |peter.hutterer@xxxxxxxxxx Flags| |fedora-review? --- Comment #1 from Peter Hutterer <peter.hutterer@xxxxxxxxxx> --- BuildRoot: is obsolete now defattr can be skipped, it just sets defaults anyway (there was a recent thread on fedora-devel) you need to add %license COPYING https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text [these three also apply to the libratbag review] tbh, I find %{bindir}/%{name} more confusing than just spelling it out, especially given that you have a second binary anyway. same with the man page also, do me a favour for this one and the libratbag bug: run fedora-review -b <bugnumber> and fix up whatever else it complains about :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review