[Bug 1309703] Review Request: libratbag - a library to configure programmable mice

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1309703

Peter Hutterer <peter.hutterer@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |peter.hutterer@xxxxxxxxxx



--- Comment #1 from Peter Hutterer <peter.hutterer@xxxxxxxxxx> ---
Couple of issues with the spec file:

summary should be capitalized correctly, it's currently a mix of upper and
lowercase

no blank line after Summary

That Source0 is a bit odd, looks like
https://github.com/libratbag/libratbag/archive/v0.2.tar.gz is sufficient?

BuildRequires: mtdev-devel?

IMO we should package libratbag/liblur as separate packages

Typo in the last changelog msg, but best to compress them into a single 
"Initial package" with a -1 release anyway.

rpmlint says:
libratbag.spec: W: patch-not-applied Patch0:
0001-tools-remove-no-install-flag-for-lur-command.patch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]