https://bugzilla.redhat.com/show_bug.cgi?id=1270317 --- Comment #9 from gil cattaneo <puntogil@xxxxxxxxx> --- (In reply to Tomas Repik from comment #8) > Now I know why: > > lz4-java.x86_64: E: no-binary > > > add BuildArchitectures: noarch to the SPEC file > > No, this will never happen the build depends on the architecture of the system according to the library used (lz4), it is not possible that both noarch > > lz4-java.x86_64: W: only-non-binary-in-usr-lib > > > There are only non binary files in /usr/lib so they should be in /usr/share > > > Possibly could just be ignored > > The artifact is installed in /usr/lib/java (%{_jnidir}) see https://fedoraproject.org/wiki/Packaging:Java#Packaging_JAR_files_that_use_JNI and it is all that there is to say / write > The package is really good, only thing is with that bundled xxhash, I don't > know if it could be removed later. Here is the review: see https://fedoraproject.org/w/index.php?title=Packaging:No_Bundled_Libraries&oldid=406058#Requirement_if_you_bundle > Package Review > ============== > > [?]: Every binary RPM package which stores shared library files (not just > symlinks) in any of the dynamic linker's default paths, must call > ldconfig in %post and %postun. Is no necessary for a JNI library > [!]: Package contains no bundled libraries without FPC exception. Is no MORE necessary > Some non-blockers > - no need to remove .jar .class files there are not any Done > - a typo in the comment on %check section: wast > waste Done > - no ${libdir} in build.xml ( sed -i 's|${libdir}|%{_libdir}|' build.xml) Seriously? What guidelines do you use? We use only: https://fedoraproject.org/wiki/Packaging:Java https://fedorahosted.org/released/javapackages/doc/ > - patches should link to upstream bugs/comments/lists Is no necessary, comments are available and the patches are specific only for Fedora > [!]: Package contains no bundled libraries without FPC exception. See above > [?]: Package should compile and build into binary rpms on all supported > architectures. It is already covered > Java: > [x]: Packages are noarch unless they use JNI > Note: lz4-java subpackage is not noarch. Please verify manually > Use of JNI -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review