[Bug 1305737] Review Request: reprepro - Tool to handle local repositories of Debian packages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1305737



--- Comment #7 from Jens Lody <fedora@xxxxxxxxxxx> ---
Looks fine so far, despite of a minor issue I have overlooked:
some of the scripts in the docs-folder still have the executable-bit set,
leading to doc-file-dependencies.
They should (must) be avoided, see:
https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation

Just a simple chmod -x on all files in docs is enough.
e.g.:

# Remove executable bits from files in doc-dir to avoid doc-file-dependencies
as
# required by the packaging guidelines
find docs -type f -exec chmod -x {} +


This can also be done when importing the package.

Formal review comes later this day, I have to go to doctor with my daughter
now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]