https://bugzilla.redhat.com/show_bug.cgi?id=1308581 --- Comment #2 from Peter Lemenkov <lemenkov@xxxxxxxxx> --- Thanks! (In reply to Randy Barlow from comment #1) > [!]: If (and only if) the source package includes the text of the > license(s) in its own file, then that file, containing the text of the > license(s) for the package is included in %license. > Note: The upstream repository does have a LICENSE file: > https://github.com/matwey/pybeam/blob/master/LICENSE > [!]: License file installed when any subpackage combination is installed. > Note: Add the license file to the python2 and 3 versions. Done. Apparently we uploaded to PyPi wrongly packaged tarball. I switched to the one from GitHub. > [!]: Macros in Summary, %description expandable at SRPM build time. > Note: Macros in: python2-pybeam (description), python3-pybeam > (description) > Note: I think you can use a global to set the description once, and > then use that as a macro throughout. I think the way this is done > might not work. Good catch. Indeed it didn't work this way. I just copied description text everywhere. > [!]: Consider using python2_sitelib instead of python_sitelib. Done. Thanks for the tip! > [!]: It's a preference thing, but I prefer the files section to be more > specific about what is being matched. No worries if you like this > way better. I copied it as is across the packages. I'd prefer this way (to simplify a packager's life a little more). It doesnn't harm anyone anyway :) > [!]: There's a lint warning about the Group tag. AFAIK, Group is no longer > needed or used, so I think you can just drop if if you want. I changed it to more standard. I prefer to keep this field for a while. > [!]: This spec file mixes spaces and tabs. Done! > [!]: Consider adding the upstream Readme with the doc macro. Done. > [!]: Some things are probably easier to do if you package from github > instead of PyPi (like the LICENSE and Readme files). Done. Thanks for reviewing this! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review