https://bugzilla.redhat.com/show_bug.cgi?id=1189015 --- Comment #21 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- (In reply to Antonio Trande from comment #20) > (In reply to Dominik 'Rathann' Mierzejewski from comment #19) > > (In reply to Antonio Trande from comment #18) > > > Package Review > > > ============== > > > > > > Legend: > > > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > > > [ ] = Manual review needed > > > > > > > > > Issues: > > > > > - doc/sphinx/source/logos is released under CC-BY-ND license. > > > I guess -doc subpackage must contain an own License tag: > > > License: CC-BY-ND and GPLv2+ > > > > Why? These two licenses are already in the main package license list. > > In the -doc package there is not any files distributed under BSD or MIT or > NCSA license. Therefore, license have to be specified. Alright, I'll correct the license field there, then. > > > - -doc subpackage does not provide its own doc files > > > (LICENSE AUTHORS CHANGELOG README SUMMARY.txt) > > > > Should it? > > They may contain unspecified informations in the documentation files; of > course, we can also omit them even if -doc is a stand-alone package. It can be installed independently of the main package, but I don't see the point in duplicating those files in it. > > > - The libxdr code for accessing Gromacs trajectories including our > > > modifications is published under the Lesser GNU Public Licence > > > (LGPL). > > > LGPLv2 license is missing. > > > > I can't find any file stating the above. Please tell me where you found this > > information, exactly. > > MDAnalysis/coordinates/xdrfile/src That directory contains just one file: dcd.c, which says this at the top: /* MDAnalysis --- http://mdanalysis.googlecode.com Copyright (c) 2006-2011 Naveen Michaud-Agrawal, Elizabeth J. Denning, Oliver Beckstein, and contributors (see website for details) Released under the GNU Public Licence, v2 or any higher version Please cite your use of MDAnalysis in published work: N. Michaud-Agrawal, E. J. Denning, T. B. Woolf, and O. Beckstein. MDAnalysis: A Toolkit for the Analysis of Molecular Dynamics Simulations. J. Comput. Chem. 32 (2011), 2319--2327, in press. */ Please point me to the exact file where you found the LGPLv2 reference. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review