https://bugzilla.redhat.com/show_bug.cgi?id=1189015 --- Comment #19 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- (In reply to Antonio Trande from comment #18) > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > [ ] = Manual review needed > > > Issues: > ======= > - Permissions on files are set properly. > Note: See rpmlint output > See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions Fixed the permissions. > - doc/sphinx/source/logos is released under CC-BY-ND license. > I guess -doc subpackage must contain an own License tag: > License: CC-BY-ND and GPLv2+ Why? These two licenses are already in the main package license list. > - -doc subpackage does not provide its own doc files > (LICENSE AUTHORS CHANGELOG README SUMMARY.txt) Should it? > - The libxdr code for accessing Gromacs trajectories including our > modifications is published under the Lesser GNU Public Licence > (LGPL). > LGPLv2 license is missing. I can't find any file stating the above. Please tell me where you found this information, exactly. > - Package does not provide python2-MDAnalysis (see Provides list) > Since, sooner or later, this software will support Python3, I think it's > better to package a python2-MDAnalysis already now. > http://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file > - python_provide macro is missing Done. > - Please, fix non-standard-executable-perm and unused-direct-shlib-dependency > errors (see rpmlint output) Fixed the 775 permissions. [...] > Rpmlint (installed packages) > ---------------------------- > python-MDAnalysis.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/python2.7/site-packages/MDAnalysis/lib/_transformations.so > /lib64/libpthread.so.0 > python-MDAnalysis.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/python2.7/site-packages/MDAnalysis/lib/c_distances_openmp.so > /lib64/libpthread.so.0 > python-MDAnalysis.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/python2.7/site-packages/MDAnalysis/lib/c_distances.so > /lib64/libpthread.so.0 > python-MDAnalysis.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/python2.7/site-packages/MDAnalysis/lib/qcprot.so > /lib64/libpthread.so.0 The -pthread option in gcc command used to compile these comes from python distutils and I'm not sure it's safe to drop it, considering our python interpreter is built with thread support. Spec URL: https://rathann.fedorapeople.org/review/python-MDAnalysis/python-MDAnalysis.spec SRPM URL: https://rathann.fedorapeople.org/review/python-MDAnalysis/python-MDAnalysis-0.13.0-3.fc23.src.rpm * Fri Feb 12 2016 Dominik Mierzejewski <rpm@xxxxxxxxxxxxxx> 0.13.0-3 - backport a fix for failing tests on f24 (due to numpy 1.11 changes) - install LICENSE with the doc subpackage as well - move building of docs to the build section - use some python-related convenience macros -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review