https://bugzilla.redhat.com/show_bug.cgi?id=1305655 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #4 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- rpmlint: liblsl.src:18: W: macro-in-comment %{name} liblsl.src:18: W: macro-in-comment %{version} liblsl.src:18: W: macro-in-comment %{commit} liblsl.src:18: W: macro-in-comment %{SOURCE0} liblsl.src: E: specfile-error warning: Macro expanded in comment on line 18: # git archive --prefix=%{name}-%{version}/ %{commit} `ls | grep -v '^external$'` | xz > %{SOURCE0} liblsl.src: E: specfile-error You really should fix those because rpm will complain about those on every build (replace % with %%). You should also add Provides: bundled(boost-endian) Provides: bundles(portable-archive) I don't think it'll make any practical difference, but the guidelines require that [1], and there's no reason not to. [1] https://fedoraproject.org/wiki/Packaging:Guidelines#Bundling_and_Duplication_of_system_libraries There's a number of warnings during build about initialization issues in the code... You might want to look into those. Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review