Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libntlm - library that implement NTLM authentication derived from Samba sources. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245080 pertusus@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |pertusus@xxxxxxx ------- Additional Comments From pertusus@xxxxxxx 2007-06-21 03:21 EST ------- Everything is almost fine * rpmlint is almost silent W: libntlm mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 12) You can fix it if you like. * free software with license included * follow naming and packaging guidelines * sane provides: Provides: libntlm.so.0 * match upstream 14e8aa077e032ae353b885a6d82ee668 libntlm-0.3.13.tar.gz * %files section right * development symlink and headers in -devel * no static lib It would be nice to have a description of the API, but there is none upstream, so... There is one real issue (apart from the tab in the spec file), the source file timestamp isn't kept: $ ls -l libntlm-0.3.13.tar.gz ../SOURCES/libntlm-0.3.13.tar.gz -rw-rw-r-- 1 dumas dumas 419505 mar 27 18:40 libntlm-0.3.13.tar.gz -rw-rw-r-- 1 dumas dumas 419505 jun 20 22:04 ../SOURCES/libntlm-0.3.13.tar.gz So, please when you import the package use a source file with the right timestamp. This can be achieved with wget -N or spectool -g. It is APPROVED, and I'll sponsor you when gsasl and msmtp are also approved. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review