[Bug 1286885] Review Request: orthorobot - A perspective based puzzle game

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1286885

Jiri Konecny <jkonecny@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jkonecny@xxxxxxxxxx



--- Comment #2 from Jiri Konecny <jkonecny@xxxxxxxxxx> ---
When you have this line:
%{_datadir}/%{name}

you don't need this:
%{_datadir}/%{name}/%{name}.love


The first line tells the rpm that your package owns whole directory
%{_datadir}/%{name} with all contents inside.

Please remove it.


The source link in comment is invalid, please fix the link:
https://github.com/Stabyourself/orthorobot/archive/GITHASH.zip

It doesn't matter the Source is from github you should then point the link to
this github. You can use something like this:
Source0: https://github.com/Stabyourself/orthorobot/archive/%{version}.tar.gz

Also the Source1 must be a link to somewhere. If you can, you should add it to
upstream and if they don't want it please upload it somewhere (the another git
repository could be used).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]