[Bug 1306299] Review Request: perl-Time-Moment - Represents a date and time of day with an offset from UTC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1306299



--- Comment #1 from Petr Šabata <psabata@xxxxxxxxxx> ---
* Consider bumping the CBOR-XS version constraint to 1.3 to guarantee the
  required 1.25 features are available.

* The required version of Sereal is `2.060'.  That should work fine; we ship
  v3+ in all branches and this module doesn't have a bad versioning history
yet.

* You can drop a number of buildtime deps:
  - ExtUtils::ParseXS -- the code is not called
  - File::Temp -- neither is this
  - Pod::Html -- nor this (only the default text README is generated)
  - Pod::Man -- nor this
  - Time::HiRes -- this one is only needed on systems without gettimeofday(2)

* You should also drop the Time::HiRes runtime dependency.

* This package bundles the `c-dt' library.
  https://github.com/chansen/c-dt
  You should provide the bundled symbol, e.g. `bundled(c-dt)'.

* c-dt is distributed under the two-clause BSD license.  Reflect that in your
  License tag with `(GPL+ or Artistic) and BSD'.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]