https://bugzilla.redhat.com/show_bug.cgi?id=1305382 --- Comment #3 from Raphael Groner <projects.rg@xxxxxxxx> --- Hi Denis, thanks for the review and your feedback. > Remarks: > -------- > 1) If you're planning to provide the package for epel7 or older Fedora > versions, `%global _hardened_build 1` is required. Recent Fedoras though don't > need it anymore; Currently, I do not see any need for EPEL or older Fedoras. This package is dedicated to developers that want to enhance dreamchess with extensions, though upstream does not provide any user documentation - may be worth an issue to report. 2) Please add all BRs: coreutils, gcc-c++, sed; Not a good idea IMHO. You can expect everything being installed that rpm depends on. As bash (and mock installing bash) depends on coreutils' functionality and rpm package depends on it, we can guess a functional build environment when rpm is installed by rpmbuild. https://lists.fedoraproject.org/pipermail/devel/2015-June/211423.html 3) README.md isn't a pure license; it can be simply in `%doc`; 4) Please use a sane description for `devel` subpackage. At least, "This package contains the header files and libraries for developing with %{name}." or whatever you'd like to use for this package; Fixed. Links are the same. 5) What's wrong with tests? Are they provided? OpenGL can not work with framebuffer of a virtual Xorg in mock/koji. No idea how to fix. # libGL error: No matching fbConfigs or visuals found # libGL error: failed to load driver: swrast 6) Better get rid of macros in comments to eliminate rpmlint warnings. That's intentional as a reminder cause of the failing tests and should not harm on koji for the official builds, see above. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review