https://bugzilla.redhat.com/show_bug.cgi?id=1306353 Neal Gompa <ngompa13@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ngompa13@xxxxxxxxx --- Comment #3 from Neal Gompa <ngompa13@xxxxxxxxx> --- I did a once-over of your package and noticed a few things: * Where's the Python 3 module? libunity does support Python 3, and the Ubuntu package provides it as part of the "gir1.2-unity-5.0" package. * Please do not use unversioned Python macros (like %{__python}, %{python_sitearch}, etc.). Please use the versioned ones so that unexpected things don't happen in the future (like the target of the unversioned ones switching on you). * When trying to do a soversion lock, please don't use ".so.X*", as that glob will potentially allow bad things to happen (if the soversion jumps a ton, we might not notice). Please instead split into two: ".so.X" and ".so.X.*". That properly locks the soversion down. * Please check to be sure that you aren't repeating the work of file triggers in releases of Fedora that support and use them. I believe glib-compile-schemas falls under one of these, per this message[0]. Starting with Fedora 24, this action will be handled automatically, so please guard these out for F24+. * Please somehow indicate in the Version or Release field that this is the version shipped with Ubuntu Wily. This will be extremely important as this library will likely be upgraded as Canonical upgrades it in Ubuntu before each release (Xenial coming up soon!). [0]: https://lists.fedoraproject.org/pipermail/desktop/2015-August/012685.html -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review