[Bug 1267009] Review Request: ola - a framework for controlling entertainment lighting equipment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1267009



--- Comment #25 from Michael Schwendt <bugs.michael@xxxxxxx> ---
> %post devel -p /sbin/ldconfig
> %postun devel -p /sbin/ldconfig

As I've seen such scriptlets in -devel packages several times in late 2015,
where does this come from?

It is very unusual for -devel packages to run ldconfig, because ldconfig is a
tool for the runtime linker cache whereas -devel packages only contain symlinks
and files for development-time. If a -devel package doesn't install any runtime
lib, it is superfluous to run ldconfig.


> %package data
> Group:          Development/Libraries
> Summary:        data for OLA

Sounds like the wrong group for the files in that package. The same group as
the base package would be more sane.  ( /usr/share/doc/rpm/GROUPS )


> %check
> export LD_LIBRARY_PATH="%buildroot%{_libdir}"
> make check %{!?el6:%{?_smp_mflags}} #el6 has problems with parralel building
> find %buildroot -name "*\.la" -delete
> find %buildroot -name "*\.a" -delete
> 
> %install

Note that %check is executed _after_ %install, so moving the section below the
%install section would be more logical. Prior to %install, %buildroot would be
empty, btw.


> %files data
> %{_datadir}/olad
> %dir %{_datadir}/ola
> %{_datadir}/ola/pids

As a hint here, increase readability of a %files section with explicit trailing
'/' on directories:

  %files data
  %{_datadir}/olad/
  %dir %{_datadir}/ola
  %{_datadir}/ola/pids/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]