[Bug 1304040] Review Request: docker-anaconda-addon - Anaconda kickstart support for Docker

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1304040



--- Comment #1 from David Shea <dshea@xxxxxxxxxx> ---
- The github archive doesn't include translations. Source0 should be the make
release archive instead.

- Related to that, po/Makefile doesn't use $(DESTDIR)

- Unless I missed something, python3-polib and python3-pylint do not need to be
in the Requires.

- There might as well be a %check, since you're pulling in pylint as a
BuildRequires. But for that python3-pylint should actually be
python3-pocketlint, and anaconda-core would need to be added as a BuildRequires
for the imports. (and probably also python3-sphinx_rtd_theme since docs/conf.py
gets checked) Or just drop the pylint BuildRequires since it gets checked in
jenkins already anyway.

- I don't think python3-devel is needed either, since none of the usual python
macros are being used.

- Huh, nothing owns /usr/share/anaconda/addons. I guess we oughta fix that in
anaconda.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]