https://bugzilla.redhat.com/show_bug.cgi?id=1303819 Denis Fateyev <denis@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #5 from Denis Fateyev <denis@xxxxxxxxxxx> --- It's OK to have py2 and py3 BRs on the top, so you can place BuildRequires: python2-devel BuildRequires: python3-devel together, not putting py3 BRs into py3 package. Althought is's matter of taste. As for changelog entries, better to put an empty line between items, otherwise you will get ragged changelog during the next releng mass rebuild - they use 3-line format. You can see the difference like that: $ rpmdev-bumpspec -V python-tinydb.spec -c "new rebuild" You may also consider providing the package in epel7, but it's up to you. Otherwise the package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review