https://bugzilla.redhat.com/show_bug.cgi?id=1265628 Tomas Hozza <thozza@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(psimerda@redhat.c | |om) --- Comment #36 from Tomas Hozza <thozza@xxxxxxxxxx> --- (In reply to Pavel Šimerda (pavlix) from comment #35) > (In reply to Tomas Hozza from comment #29) > > Issues > > ------ > > [!]: Requires correct, justified where necessary. > > - According to > > https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd you > > should also BuildRequire "systemd". > > We depend on systemd-devel. That does not solve the problem, since systemd-devel does NOT have any dependency on systemd package. systemd package ships "/usr/lib/rpm/macros.d/macros.systemd" which defines the systemd RPM macros, therefore you MUST add the dependency. http://koji.fedoraproject.org/koji/fileinfo?rpmID=7008036&filename=/usr/lib/rpm/macros.d/macros.systemd > > [!]: Package contains systemd file(s) if in need. > > - Please add also the template unit dhcpcd@.service > > I'm not sure this is useful at all, NetworkManager also doesn't have > @.service unit, but it's there now. > > > [!]: Latest version is packaged. > > - latest version is 6.10.1 > > Latest version is used now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review