[Bug 1305263] Review Request: perl-Text-Fuzzy - Partial string matching using edit distances

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1305263



--- Comment #3 from Denis Fateyev <denis@xxxxxxxxxxx> ---
(In reply to Petr Šabata from comment #1)
> * Missing builddeps: gcc, perl-devel

Added.

> * I'm not sure $LDFLAGS contains anything; consider using
> %{?__global_ldflags}.

In RHEL7 it contains not much though:
  # rpm -E '%{?__global_ldflags}'
  -Wl,-z,relro

Although the changed version should fit everything:
  export LDFLAGS="%{?__global_ldflags} -Wl,-z,now -Wl,--as-needed"

> * Consider packaging the examples directory as %doc.

Added.

> * And again, this module also technically requires Test::More 0.88+.  Don't
>   worry about it; I'm just mentioning it for completeness :)

Well, since epel7 has 0.98 (and Fedoras even newer) I initially dropped it; but
returned back for now.

Updated version:
Spec: http://www.fateyev.com/RPMS/Fedora22/perl-Text-Fuzzy.spec
SRPM: http://www.fateyev.com/RPMS/Fedora22/perl-Text-Fuzzy-0.24-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]