[Bug 1304774] Review Request: perl-Function-Parameters - Subroutine definitions with parameter lists

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1304774

Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-Function-Parameters-1.0703-1.fc24.x86_64.rpm | sort |
uniq -c
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libc.so.6(GLIBC_2.4)(64bit)
      1 libperl.so.5.22()(64bit)
      1 perl(:MODULE_COMPAT_5.22.1)
      1 perl(:VERSION) >= 5.14.0
      1 perl(Carp)
      1 perl(Moo)
      1 perl(Moose::Util::TypeConstraints)
      1 perl(XSLoader)
      1 perl(overload)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 rtld(GNU_HASH)

Binary requires are Ok.

$ rpm -qp --provides perl-Function-Parameters-1.0703-1.fc24.x86_64.rpm | sort |
uniq -c
      1 perl(Function::Parameters) = 1.0703
      1 perl(Function::Parameters::Info) = 1.0703
      1 perl(Function::Parameters::Param)
      1 perl-Function-Parameters = 1.0703-1.fc24
      1 perl-Function-Parameters(x86-64) = 1.0703-1.fc24

Binary provides are Ok.

$ rpmlint ./perl-Function-Parameters*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

Rpmlint is ok

BuildRequires 
FIX: Build-require 'perl(warnings)' is listed twice. Please remove it from
     run-time section
FIX: Missing build-require 'gcc'

Please correct all 'FIX' issues.

Otherwise the package looks good.
Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]