https://bugzilla.redhat.com/show_bug.cgi?id=1297215 Roman Tsisyk <roman@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags| |fedora-review+ --- Comment #8 from Roman Tsisyk <roman@xxxxxxxxxx> --- + Fixed: license file is present, %license macro is used + Fixed: BuildRequires: systemd instead of systemd-utils + Fixed: %post %preun %postun scriptlets for systemd were added + Fixed: man pages installed uncompressed + Fixed: RPM spec now compiles JS from sources during %build stage + Fixed: bundled mbedtls is not used anymore + Fixed: pdns and dnsdist relation is now clear for me + license is acceptable (GPLv2) + BuildRequires are OK + %check is present and all tests pass + mock builds [1] are ok + installs and works properly [2] + rpmlint is OK - only false-positive spelling-error Package is APPROVED. Further things to consider (up to you): * it would be nice to include a sample configuration file * bundled yahttp is used at least by pdns and your package, probably yahttp needs its own package [1] tested on fedora-rawhide-x86_64 and fedora-23-armv7hl [2] tested on fedora23-armv7hl with a configuration file from https://github.com/PowerDNS/pdns/blob/master/pdns/dnsdistconf.lua -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review