https://bugzilla.redhat.com/show_bug.cgi?id=1304882 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |jdulaney@xxxxxxxxxxxxxxxxx --- Comment #16 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd says "%systemd_requires macro must not be used". If the generators fails, it will not log anything. Actually that's another error in the generator script. See http://www.freedesktop.org/software/systemd/man/systemd.generator.html#Notes. For the permissions, (0640,root,geekotest) would seem more natural then. For example cups has a bunch of files /etc/cups that follow this pattern, /etc/ssmtp. It's nice because you can provide read permissions to other users by adding them to the group. Using (0460,geekotest,root) doesn't achieve the purpose of preventing writes, because the owner of the file has permission to chmod +x. I don't know how security sensitive the file is, but if you're going to implement a lock down of the file, I think it should be done properly, not least because bad patterns tend to get copied and end up in more important places. I wouldn't worry about the upstream permissions: if you have an %attr() already, also setting the mode doesn't change much. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review