https://bugzilla.redhat.com/show_bug.cgi?id=1304882 --- Comment #13 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- (In reply to awilliam@xxxxxxxxxx from comment #12) > "%{?systemd_requires} is forbidden by the guidelines. I don't think we gain > anything by that rule, but it's on the books." > > Thanks, I'll...er...do something about that? Expand it. See https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd. > "What about parallel build?" > > The compile step is pretty short anyhow, so I guess I never thought about > it. I can see. > > "I think user/group creation scriptlets should be suffixed with "|| :". > They should not be fatal to installation." > > Well, there are samples on the policy page for those, and they don't have > "|| :". https://fedoraproject.org/wiki/Packaging:UsersAndGroups That's true, but I think that those guidelines are from old times. Nowadays we try not to fail in the scriptlets for any reason if at all possible. For this package, if the scriptlets fail, nothing terrible happens. In fact tmpfiles will report the failure nicely in the normal logs. > "Also emitting message from %post is a bit unusual." > > Yeah, it's kinda unusual for Fedora I guess, but it seemed useful so I kept > it. Of course it should at least be in the httpd subpackage now :) Maybe I > can add a README or something instead, I'll see what I feel. Yeah, that's why I said "unusual". Unusual is not wrong. I guess that if it sticks out too much and annoys people, somebody will file a bug report. > "Strictly speaking, the generator is wrong, because generators cannot rely > on /var being mounted. It will not operate correctly if someone has a system > with separate /var partitions." > > Is there a fix or change you can recommend? Honestly this just came from the > SUSE spec, I don't even know what it does. It adds openqa-worker@.service instance for every item in /var/lib/openqa/pool/[0-9]* to the openqa-worker.target. The annoying thing is that things will break in a confusing way if /var is separate: after initial installation things will be fine, and then after a reboot the units will not be generated as expected. But maybe that's not that much of a problem, after all this package will not be installed by too many random people. There's an easy workaround in case /var is separate: just run 'systemctl add-wants openqa-worker.target openqa-worker@<x>.service'. (Pfff, it seems that this doesn't work for instances. Oh, systemd! If think it might be fixed by Jan Synacek's PR that is awaiting review. But the symlink can always be added by hand.) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review